drawing highlighting

[corvid]

I was looking at draw() calls for the view, and I saw how there was a
call for every time that the mouse moved when highlighting even though
the text highlighted didn't necessarily change.

Here's quick code to demonstrate that there are plenty of redundant ones.
I don't know the iterator code well enough to know whether that's the
right place to do anything about it, though...

[Sebastian Geerken]

Post by corvid
I was looking at draw() calls for the view, and I saw how there was a
call for every time that the mouse moved when highlighting even though
the text highlighted didn't necessarily change.
Here's quick code to demonstrate that there are plenty of redundant ones.
I don't know the iterator code well enough to know whether that's the
right place to do anything about it, though...

Your patch makes sense, and I've committed it (slightly changed).

The purpose of Iterator::highlight is to change a state, and so it
should be checked, whether the state has changed at all.

Sebastian

[corvid]

For highlighting in a single word: