Discussion:
[patch] a_Dpip_send_cmd
p***@public.gmane.org
2013-01-12 21:41:37 UTC
Permalink
http://www.inventati.org/noname/dillo/dpip-send-cmd.patch

Patch adds a_Dpip_send_cmd and helper function a_Dpip_vbuild_cmd.

This way common pattern

d_cmd = a_Dpip_build_cmd(format, ...);
st = a_Dpip_dsh_write_str(sh, flush, d_cmd);
dFree(d_cmd);

can be replaced with

st = a_Dpip_send_cmd(sh, flush, format, ...);
Jorge Arellano Cid
2013-01-14 13:52:03 UTC
Permalink
Hi,
Post by p***@public.gmane.org
http://www.inventati.org/noname/dillo/dpip-send-cmd.patch
Patch adds a_Dpip_send_cmd and helper function a_Dpip_vbuild_cmd.
This way common pattern
d_cmd = a_Dpip_build_cmd(format, ...);
st = a_Dpip_dsh_write_str(sh, flush, d_cmd);
dFree(d_cmd);
can be replaced with
st = a_Dpip_send_cmd(sh, flush, format, ...);
The idea looks good, and after applying it, the patch doesn't
compile; the problem is trivial but it makes me hesitate.

Please at least check the patch compiles, and that the functionality
it changes/modifies works for every case, before submitting.

TIA.
--
Cheers
Jorge.-
p***@public.gmane.org
2013-01-15 23:49:35 UTC
Permalink
I have fixed the patch and reread it.

Link is the same:
http://www.inventati.org/noname/dillo/dpip-send-cmd.patch

Loading...