allow_white_bg

[Sebastian Geerken]

Hi!

It seems that I'm getting old that I tried to set the option
"allow_white_bg" to "false"; to find out that the replacement color is
hardcoded! If I haven't missed something, and noone objets, I'll add a
prefs variable "white_bg_replacement".

BTW: is there a reason that there is still a prefs variable
"bg_color", while fonts (the actual fonts, not the font classes) are
now defined by CSS?

Sebastian

[Johannes Hofmann]

Hi Sebastian,

Gesendet: Montag, 19. August 2013 um 10:32 Uhr
Betreff: [Dillo-dev] allow_white_bg
Hi!
It seems that I'm getting old that I tried to set the option
"allow_white_bg" to "false"; to find out that the replacement color is
hardcoded! If I haven't missed something, and noone objets, I'll add a
prefs variable "white_bg_replacement".

Sounds good. white_bg_replacement would replace allow_white_bg, right?

BTW: is there a reason that there is still a prefs variable
"bg_color", while fonts (the actual fonts, not the font classes) are
now defined by CSS?

There are some differences in behavior between setting bg_color option
and having body {background-color: <something>} in style.css.
I'm not sure whether they justify the existence of the bg_color option.
But I can't really decide, as I don't use bg_color normally.

Cheers,
Johannes

[Sebastian Geerken]

Post by Johannes Hofmann

Post by Sebastian Geerken
It seems that I'm getting old that I tried to set the option
"allow_white_bg" to "false"; to find out that the replacement color is
hardcoded! If I haven't missed something, and noone objets, I'll add a
prefs variable "white_bg_replacement".

Sounds good. white_bg_replacement would replace allow_white_bg, right?

Currently, I've added another option, so you must specify something
like:

allow_white_bg=NO
white_bg_replacement=0xf0f0d0

The standard for white_bg_replacement is 0xe0e0a3, the value
hard-coded before.

Your suggestion sounds good to, only to specify white_bg_replacement,
which has a standard value of "undefined". I'm open to both.

Sebastian

[Sebastian Geerken]

Post by Sebastian Geerken

Post by Johannes Hofmann

Post by Sebastian Geerken
It seems that I'm getting old that I tried to set the option
"allow_white_bg" to "false"; to find out that the replacement color is
hardcoded! If I haven't missed something, and noone objets, I'll add a
prefs variable "white_bg_replacement".

Sounds good. white_bg_replacement would replace allow_white_bg, right?

Currently, I've added another option, so you must specify something
allow_white_bg=NO
white_bg_replacement=0xf0f0d0
The standard for white_bg_replacement is 0xe0e0a3, the value
hard-coded before.
Your suggestion sounds good to[o], only to specify white_bg_replacement,
which has a standard value of "undefined". I'm open to both.

I've pushed my variant (two variables); feel free to change.

Back to floats ...

Sebastian