Discussion:
PATCH: uicmd.cc prefs.save_dir cleanup
Jeremy Henty
2012-12-28 15:03:23 UTC
Permalink
uicmd.cc exports a get()/set() interface to the default save directory
that is never used elsewhere, and used only trivially internally. It
also rereads prefs.save_dir at every save, which is redundant. It
would be simpler to have an init() interface that is called once.
There would be no change to the user.

Patch attached. Thoughts?

Regards,

Jeremy Henty
corvid
2012-12-28 17:44:12 UTC
Permalink
Post by Jeremy Henty
uicmd.cc exports a get()/set() interface to the default save directory
that is never used elsewhere, and used only trivially internally. It
also rereads prefs.save_dir at every save, which is redundant. It
would be simpler to have an init() interface that is called once.
There would be no change to the user.
Patch attached. Thoughts?
Seems like a good change to make...
Jeremy Henty
2012-12-30 12:20:20 UTC
Permalink
Post by corvid
Post by Jeremy Henty
uicmd.cc exports a get()/set() interface to the default save directory
that is never used elsewhere, and used only trivially internally. It
also rereads prefs.save_dir at every save, which is redundant. It
would be simpler to have an init() interface that is called once.
There would be no change to the user.
Patch attached. Thoughts?
Seems like a good change to make...
OK, committed.

Regards,

Jeremy Henty

Loading...